Re: [VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

2018-08-15 Thread Kevin Lu
Hi All, Forgot to post this earlier, but I cancelled this KIP as we determined this is a bug fix. Could a committer review/merge the PR ( https://github.com/apache/kafka/pull/5383)? Colin has already finished and approved a review. Thanks! Regards, Kevin On Wed, Jul 25, 2018 at 10:12 AM Ted

Re: [VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

2018-07-25 Thread Ted Yu
+1 On Wed, Jul 25, 2018 at 9:49 AM Kevin Lu wrote: > Hi All, > > I am calling a vote for KIP-344 > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter > . > > If any committer feels that this minor change does not need

[VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

2018-07-25 Thread Kevin Lu
Hi All, I am calling a vote for KIP-344 https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter . If any committer feels that this minor change does not need to go through the KIP process, then feel free to leave a code review