[VOTE] KIP-35: Retrieve protocol version - Round 2

Hey Guys, I would like to re-initiate the voting process for *KIP-35: Retrieve protocol version*. KIP-35 can be accessed here . Following are a couple of related PRs. 1. KAFKA-3307: Add ApiVersion request/

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 On Thu, Apr 21, 2016 at 4:48 PM, Ashish Singh wrote: > Hey Guys, > > I would like to re-initiate the voting process for *KIP-35: Retrieve > protocol version*. > > KIP-35 can be accessed here > . > Following

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 On Thu, Apr 21, 2016 at 5:07 PM, Gwen Shapira wrote: > +1 > > On Thu, Apr 21, 2016 at 4:48 PM, Ashish Singh wrote: > > Hey Guys, > > > > I would like to re-initiate the voting process for *KIP-35: Retrieve > > protocol version*. > > > > KIP-35 can be accessed here > > < > https://cwiki.apach

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 On Thu, Apr 21, 2016 at 5:25 PM, Guozhang Wang wrote: > +1 > > On Thu, Apr 21, 2016 at 5:07 PM, Gwen Shapira wrote: > > > +1 > > > > On Thu, Apr 21, 2016 at 4:48 PM, Ashish Singh > wrote: > > > Hey Guys, > > > > > > I would like to re-initiate the voting process for *KIP-35: Retrieve > > >

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 (non-binding) On Thu, Apr 21, 2016 at 5:26 PM, Ewen Cheslack-Postava wrote: > +1 > > On Thu, Apr 21, 2016 at 5:25 PM, Guozhang Wang wrote: > > > +1 > > > > On Thu, Apr 21, 2016 at 5:07 PM, Gwen Shapira wrote: > > > > > +1 > > > > > > On Thu, Apr 21, 2016 at 4:48 PM, Ashish Singh > > wrote:

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 (non binding) On Friday, 22 April 2016, Jason Gustafson wrote: > +1 (non-binding) > > On Thu, Apr 21, 2016 at 5:26 PM, Ewen Cheslack-Postava > > wrote: > > > +1 > > > > On Thu, Apr 21, 2016 at 5:25 PM, Guozhang Wang > wrote: > > > > > +1 > > > > > > On Thu, Apr 21, 2016 at 5:07 PM, Gwen Sha

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

Ashish, Just a couple of clarifications. 1. In ApiVersionRequest, we should get rid of ApiKeys since the request has an empty body, right? 2. In ApiVersionResponse, we should list ErrorCode before ApiVersions, right? Thanks, Jun On Thu, Apr 21, 2016 at 4:48 PM, Ashish Singh wrote: > Hey Guy

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

Hello Jun, On Fri, Apr 22, 2016 at 11:31 AM, Jun Rao wrote: > Ashish, > > Just a couple of clarifications. > > 1. In ApiVersionRequest, we should get rid of ApiKeys since the request has > an empty body, right? > Yes. > > 2. In ApiVersionResponse, we should list ErrorCode before ApiVersions, >

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 (non-binding) from me, assuming that the changes suggested by Jun below are included. Some minor comments. "5. Clients are recommended to use latest common supported API version." Maybe this would be clearer as: "Clients are recommended to use latest version supported by the broker and itself

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 (non-binding) One minor comment: "11: The broker returns its full list of supported ApiKeys and versions regardless of current authentication state (e.g., before SASL authentication). If this is considered to leak information SSL can be used for early authentication." It may be better to exp

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

Good point Rajini, I will clarify that. Thanks, Magnus 2016-04-22 12:35 GMT-07:00 Rajini Sivaram : > +1 (non-binding) > > One minor comment: > > "11: The broker returns its full list of supported ApiKeys and versions > regardless of current authentication state (e.g., before SASL > authenticatio

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

+1 (non-binding) On Apr 22, 2016 3:33 PM, "Magnus Edenhill" wrote: > Good point Rajini, I will clarify that. > > Thanks, > Magnus > > 2016-04-22 12:35 GMT-07:00 Rajini Sivaram : > > > +1 (non-binding) > > > > One minor comment: > > > > "11: The broker returns its full list of supported ApiKeys an

Re: [VOTE] KIP-35: Retrieve protocol version - Round 2

Ismael, thanks for the suggestions, added a bit more text to be more informative. Note that changes are made only to text and examples, the proposal remains as it was before voting was started. Magnus has already taken care of Rajini's comment. KIP-35 has passed with +3 (binding) and +6 (non-bindi