Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-30 Thread Viktor Somogyi-Vass
Hi All, I'm closing the vote as there has been a few days without any more feedback and the KIP collected 3 binding votes (Gwen, Harsha and Colin) and 2 non-binding (Mickael and Kevin) - therefore it got accepted. I'll update its status and work on the implementation (I have a WIP PR but that stil

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-25 Thread Gwen Shapira
+1 (binding) Thanks for working on this. On Wed, Oct 24, 2018, 7:28 AM Viktor Somogyi-Vass wrote: > Hi All, > > I'd like to start a vote on KIP-377: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient > . > > Summary: > The KIP basically proposes to a

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-25 Thread Kevin Lu
+1 (non-binding) Regards, Kevin On Thu, Oct 25, 2018 at 8:19 AM Harsha Chintalapani wrote: > Thanks for the KIP. +1 (binding). > -Harsha > On Oct 25, 2018, 10:40 AM -0400, Viktor Somogyi-Vass < > viktorsomo...@gmail.com>, wrote: > > Thanks for the votes so far. > > > > @Colin: yup, I've added t

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-25 Thread Harsha Chintalapani
Thanks for the KIP. +1 (binding). -Harsha On Oct 25, 2018, 10:40 AM -0400, Viktor Somogyi-Vass , wrote: > Thanks for the votes so far. > > @Colin: yup, I've added this to the KIP. Thanks. > On Thu, Oct 25, 2018 at 2:30 AM Colin McCabe wrote: > > > > Thanks, Viktor. +1 (binding). > > > > One note:

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-25 Thread Viktor Somogyi-Vass
Thanks for the votes so far. @Colin: yup, I've added this to the KIP. Thanks. On Thu, Oct 25, 2018 at 2:30 AM Colin McCabe wrote: > > Thanks, Viktor. +1 (binding). > > One note: can we add a deprecation warning when --zookeeper is used, to > indicate that this option will be phased out in the f

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-24 Thread Colin McCabe
Thanks, Viktor. +1 (binding). One note: can we add a deprecation warning when --zookeeper is used, to indicate that this option will be phased out in the future? best, Colin On Wed, Oct 24, 2018, at 05:47, Mickael Maison wrote: > +1 (non-binding) > Thanks for the KIP! > On Wed, Oct 24, 2018 at

Re: [VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-24 Thread Mickael Maison
+1 (non-binding) Thanks for the KIP! On Wed, Oct 24, 2018 at 1:28 PM Viktor Somogyi-Vass wrote: > > Hi All, > > I'd like to start a vote on KIP-377: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient. > > Summary: > The KIP basically proposes to add --bo

[VOTE] KIP-377: TopicCommand to use AdminClient

2018-10-24 Thread Viktor Somogyi-Vass
Hi All, I'd like to start a vote on KIP-377: https://cwiki.apache.org/confluence/display/KAFKA/KIP-377%3A+TopicCommand+to+use+AdminClient. Summary: The KIP basically proposes to add --bootstrap-server and --command-config option to TopicsCommand and implement topic administration with AdminClient