Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-05-02 Thread Ivan Yurchenko
Hello all, Thank you for your votes! I think we have reached a decision here to accept the KIP with the following votes: - 3x binding +1s from Chris Egerton, Yash Mayya, and Greg Harris. - 1x non-binding +1s from Knowles Atchison Jr. - No -1s. I will proceed with the implementation. Feel free

Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-05-01 Thread Greg Harris
Hi Ivan, Thank you for the KIP! I think PATCH using the same return type as PUT benefits the clients, even though the "created" field will always be false. +1 (binding) Thanks, Greg On Fri, Apr 12, 2024 at 4:31 AM Yash Mayya wrote: > > Hi Ivan, > > Thanks for reviving this KIP, I think it will

Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-04-12 Thread Yash Mayya
Hi Ivan, Thanks for reviving this KIP, I think it will be a useful addition to Connect! +1 (binding) Cheers, Yash On Tue, Apr 9, 2024 at 4:23 AM Knowles Atchison Jr wrote: > +1 (non binding) > > On Mon, Apr 8, 2024, 3:30 PM Chris Egerton > wrote: > > > Thanks Ivan! +1 (binding) from me. > >

Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-04-08 Thread Knowles Atchison Jr
+1 (non binding) On Mon, Apr 8, 2024, 3:30 PM Chris Egerton wrote: > Thanks Ivan! +1 (binding) from me. > > On Mon, Apr 8, 2024, 06:59 Ivan Yurchenko wrote: > > > Hello! > > > > I'd like to put the subj KIP[1] to a vote. Thank you. > > > > Best regards, > > Ivan > > > > [1] > > > https://cwiki.

Re: [VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-04-08 Thread Chris Egerton
Thanks Ivan! +1 (binding) from me. On Mon, Apr 8, 2024, 06:59 Ivan Yurchenko wrote: > Hello! > > I'd like to put the subj KIP[1] to a vote. Thank you. > > Best regards, > Ivan > > [1] > https://cwiki.apache.org/confluence/display/KAFKA/KIP-477%3A+Add+PATCH+method+for+connector+config+in+Connect+

[VOTE] KIP-477: Add PATCH method for connector config in Connect REST API

2024-04-08 Thread Ivan Yurchenko
Hello! I'd like to put the subj KIP[1] to a vote. Thank you. Best regards, Ivan [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-477%3A+Add+PATCH+method+for+connector+config+in+Connect+REST+API