Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-19 Thread Matthias J. Sax
Thanks for voting! @Bruno, I fixed the typo. +1 (binding) from myself. I am closing the vote as accepted with three binding +1 votes (John, Bill, Matthias) and three non-binding +1 votes (Jorge, Bruno, Navinder). -Matthias On 6/19/20 8:20 AM, Bill Bejeck wrote: > Thanks for the KIP

Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-19 Thread Bill Bejeck
Thanks for the KIP Matthias. +1 (binding) Thanks, Bill On Thu, Jun 18, 2020 at 11:51 PM John Roesler wrote: > Thanks Matthias, > > I’m +1 (binding) > > -John > > On Thu, Jun 18, 2020, at 02:21, Navinder Brar wrote: > > Hi Matthias, > > > > +1 non-binding. Thanks for the KIP. > > > > Thanks, >

Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-18 Thread John Roesler
Thanks Matthias, I’m +1 (binding) -John On Thu, Jun 18, 2020, at 02:21, Navinder Brar wrote: > Hi Matthias, > > +1 non-binding. Thanks for the KIP. > > Thanks, > Navinder  > > On Tuesday, 16 June, 2020, 06:34:19 pm IST, Bruno Cadonna > wrote: > > Hi Matthias, > > Thank you for

Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-18 Thread Navinder Brar
Hi Matthias, +1 non-binding. Thanks for the KIP. Thanks, Navinder  On Tuesday, 16 June, 2020, 06:34:19 pm IST, Bruno Cadonna wrote: Hi Matthias, Thank you for the KIP. I am +1 (non-binding). Said that, you have a typo in the "Public Interface" section. TOPLOGY_OPTIMIZATION_CONFIG

Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-16 Thread Bruno Cadonna
Hi Matthias, Thank you for the KIP. I am +1 (non-binding). Said that, you have a typo in the "Public Interface" section. TOPLOGY_OPTIMIZATION_CONFIG instead of TOPOLOGY_OPTIMIZATION_CONFIG. Best, Bruno On Tue, Jun 16, 2020 at 5:02 AM Matthias J. Sax wrote: > > Hi, > > I found a small

Re: [VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-16 Thread Jorge Esteban Quilcate Otoya
+1 Thanks Matthias. On Tue, Jun 16, 2020 at 4:02 AM Matthias J. Sax wrote: > Hi, > > I found a small inconsistency in our public API and propose a small KIP > to fix it. As the change is trivial, I skip the discussion and call > directly for a VOTE. > > > >

[VOTE] KIP-626: Rename StreamsConfig config variable name

2020-06-15 Thread Matthias J. Sax
Hi, I found a small inconsistency in our public API and propose a small KIP to fix it. As the change is trivial, I skip the discussion and call directly for a VOTE. https://cwiki.apache.org/confluence/display/KAFKA/KIP-626%3A+Rename+StreamsConfig+config+variable+name -Matthias