Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-29 Thread Lucas Bradstreet
Hi David, That is a good point that we should clarify. I think we should not commit to guaranteeing the names or the format of the particular request and response schemas themselves, though we should guarantee that they are parseable as JSON. The pre-existing trace logging did not guarantee this e

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-29 Thread David Jacot
Hi folks, I have looked at Anastasia's PR to implement this KIP and I was wondering how far we want to go with the backward compatibility of this in the future. Now that we rely on the auto-generated protocol, the outputted requests and responses use the name of the fields defined in the schema. U

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-08 Thread Anastasia Vela
Thanks everyone for the votes. In summary, the vote passed and the KIP was accepted with 3 binding and 3 non-binding +1s. Best, Anastasia On Mon, Oct 5, 2020 at 2:50 PM Jason Gustafson wrote: > +1 Thanks for the KIP! > > On Fri, Oct 2, 2020 at 4:37 PM Colin McCabe wrote: > > > Thanks, Anastasi

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-05 Thread Jason Gustafson
+1 Thanks for the KIP! On Fri, Oct 2, 2020 at 4:37 PM Colin McCabe wrote: > Thanks, Anastasia! This will be a lot easier to maintain. > > +1 (binding) > > best, > Colin > > On Wed, Sep 30, 2020, at 23:57, David Jacot wrote: > > Thanks for the KIP, Anastasia. > > > > +1 (non-binding) > > > > On

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-02 Thread Colin McCabe
Thanks, Anastasia! This will be a lot easier to maintain. +1 (binding) best, Colin On Wed, Sep 30, 2020, at 23:57, David Jacot wrote: > Thanks for the KIP, Anastasia. > > +1 (non-binding) > > On Thu, Oct 1, 2020 at 8:06 AM Tom Bentley wrote: > > > Thanks Anastasia, > > > > +1 (non-binding)

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-09-30 Thread David Jacot
Thanks for the KIP, Anastasia. +1 (non-binding) On Thu, Oct 1, 2020 at 8:06 AM Tom Bentley wrote: > Thanks Anastasia, > > +1 (non-binding) > > > On Thu, Oct 1, 2020 at 6:30 AM Gwen Shapira wrote: > > > Thank you, this will be quite helpful. > > > > +1 (binding) > > > > On Wed, Sep 30, 2020 at

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-09-30 Thread Tom Bentley
Thanks Anastasia, +1 (non-binding) On Thu, Oct 1, 2020 at 6:30 AM Gwen Shapira wrote: > Thank you, this will be quite helpful. > > +1 (binding) > > On Wed, Sep 30, 2020 at 11:19 AM Anastasia Vela > wrote: > > > > Hi everyone, > > > > Thanks again for the discussion. I'd like to start the vote

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-09-30 Thread Gwen Shapira
Thank you, this will be quite helpful. +1 (binding) On Wed, Sep 30, 2020 at 11:19 AM Anastasia Vela wrote: > > Hi everyone, > > Thanks again for the discussion. I'd like to start the vote for this KIP. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-673%3A+Emit+JSONs+with+new+auto-genera

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-09-30 Thread Lucas Bradstreet
Hi Anastasia, This looks like a great change that will make debugging cluster behavior much easier. +1 non binding. Lucas On Wed, Sep 30, 2020 at 11:19 AM Anastasia Vela wrote: > Hi everyone, > > Thanks again for the discussion. I'd like to start the vote for this KIP. > > https://cwiki.apach

[VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-09-30 Thread Anastasia Vela
Hi everyone, Thanks again for the discussion. I'd like to start the vote for this KIP. https://cwiki.apache.org/confluence/display/KAFKA/KIP-673%3A+Emit+JSONs+with+new+auto-generated+schema Thanks, Anastasia