Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Hello, I discovered a bug in the design of this metric. The bug is documented here: https://github.com/apache/kafka/pull/11805. We need to include time the producer spends waiting on topic metadata into the total blocked time. But to do this we would need to add a new producer metric that tracks

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Thanks for the KIP. +1 (non-binding) Thank you. Luke On Wed, Sep 1, 2021 at 2:36 AM Guozhang Wang wrote: > Thanks for letting us know, Rohan. > > On Tue, Aug 31, 2021 at 1:08 AM Rohan Desai > wrote: > > > FYI I've updated the metric names in the KIP to the form > ".*-time-ns-total" > > and

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Thanks for letting us know, Rohan. On Tue, Aug 31, 2021 at 1:08 AM Rohan Desai wrote: > FYI I've updated the metric names in the KIP to the form ".*-time-ns-total" > and clarified that the times being measured are in nanoseconds. > > On Wed, Jul 21, 2021 at 5:09 PM Rohan Desai > wrote: > > >

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

FYI I've updated the metric names in the KIP to the form ".*-time-ns-total" and clarified that the times being measured are in nanoseconds. On Wed, Jul 21, 2021 at 5:09 PM Rohan Desai wrote: > Now that the discussion thread's been open for a few days, I'm calling for > a vote on > >

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Thank you Rohan, +1 (binding) Best, Bruno On 02.08.21 17:54, Israel Ekpo wrote: Rohan, Thanks for working on this. Looks great. +1 from me. (non-binding) Don't forget to update the *Current State* of the KIP and include the associated *JIRA IDs* once the voting is completed.

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Rohan, Thanks for working on this. Looks great. +1 from me. (non-binding) Don't forget to update the *Current State* of the KIP and include the associated *JIRA IDs* once the voting is completed.

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Thanks for the KIP +1 from me (non binding)! Walker On Fri, Jul 30, 2021 at 1:20 PM Sophie Blee-Goldman wrote: > Thanks for updating the KIP, +1 (binding) > > -Sophie > > > On Tue, Jul 27, 2021 at 9:57 AM Guozhang Wang wrote: > > > Hello Rohan, > > > > Thanks for the KIP. As Bruno mentioned

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Thanks for updating the KIP, +1 (binding) -Sophie On Tue, Jul 27, 2021 at 9:57 AM Guozhang Wang wrote: > Hello Rohan, > > Thanks for the KIP. As Bruno mentioned in the other thread could you update > the "New Metrics" that 1) we have sub-titles for streams, producer, > consumer metrics, just

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Hello Rohan, Thanks for the KIP. As Bruno mentioned in the other thread could you update the "New Metrics" that 1) we have sub-titles for streams, producer, consumer metrics, just for clarification, and 2) update the "producer-id" etc to "client-id" to be consistent with the existing metrics.

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Hey Rohan, Thanks for pushing this KIP through. I'm +1, non-binding. Leah On Wed, Jul 21, 2021 at 7:09 PM Rohan Desai wrote: > Now that the discussion thread's been open for a few days, I'm calling for > a vote on > >

[VOTE] KIP-761: Add Total Blocked Time Metric to Streams

Now that the discussion thread's been open for a few days, I'm calling for a vote on https://cwiki.apache.org/confluence/display/KAFKA/KIP-761%3A+Add+Total+Blocked+Time+Metric+to+Streams