[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-19 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906605#comment-13906605 ] Joe Stein commented on KAFKA-1254: -- Yes! will remove the TODO also. > remove vestigial s

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906600#comment-13906600 ] Jun Rao commented on KAFKA-1254: Joe, Do you want to commit this? > remove vestigial sbt

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902336#comment-13902336 ] Jun Rao commented on KAFKA-1254: Joe, Could you check in this patch? Also, could you remo

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897303#comment-13897303 ] Jun Rao commented on KAFKA-1254: +1. We can check in after all other sub-jiras in kafka-12

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896824#comment-13896824 ] Joel Koshy commented on KAFKA-1254: --- Jun can confirm, but I believe the remaining issues

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896225#comment-13896225 ] Neha Narkhede commented on KAFKA-1254: -- I thought that we want to keep sbt even in 0.

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-09 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896163#comment-13896163 ] Joe Stein commented on KAFKA-1254: -- Updated reviewboard https://reviews.apache.org/r/1788

[jira] [Commented] (KAFKA-1254) remove vestigial sbt

2014-02-09 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896160#comment-13896160 ] Joe Stein commented on KAFKA-1254: -- Created reviewboard https://reviews.apache.org/r/1788