[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395268#comment-14395268
]
Joel Koshy commented on KAFKA-1546:
---
+1 on the latest doc updates. I can check in the do
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389441#comment-14389441
]
Aditya Auradkar commented on KAFKA-1546:
Good point Jun. I've added those metrics
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389322#comment-14389322
]
Jun Rao commented on KAFKA-1546:
For the doc change, do we need to make the following chan
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384759#comment-14384759
]
Aditya Auradkar commented on KAFKA-1546:
Added a patch for the HTML changes.
> Au
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384734#comment-14384734
]
Aditya Auradkar commented on KAFKA-1546:
[~junrao] I found references to this conf
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384654#comment-14384654
]
Joel Koshy commented on KAFKA-1546:
---
https://svn.apache.org/repos/asf/kafka/site/083/des
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384620#comment-14384620
]
Aditya Auradkar commented on KAFKA-1546:
[~jjkoshy] Where can I find the html to c
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384610#comment-14384610
]
Joel Koshy commented on KAFKA-1546:
---
Actually, I'm referring to the documentation html -
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384406#comment-14384406
]
Jun Rao commented on KAFKA-1546:
Since the broker has moved to ConfigDef, we can generate
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384382#comment-14384382
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384242#comment-14384242
]
Joel Koshy commented on KAFKA-1546:
---
Patch looks good. This is another ticket for which
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383086#comment-14383086
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380696#comment-14380696
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370193#comment-14370193
]
Aditya Auradkar commented on KAFKA-1546:
[~nehanarkhede][~junrao] I've incorporate
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366152#comment-14366152
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363672#comment-14363672
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362581#comment-14362581
]
Neha Narkhede commented on KAFKA-1546:
--
[~aauradkar] Thanks for the patch. Overall, t
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359925#comment-14359925
]
Aditya Auradkar commented on KAFKA-1546:
I ran a bunch of tests on my patch for KA
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359371#comment-14359371
]
Aditya Auradkar commented on KAFKA-1546:
[~jkreps]I'm going to test it like you su
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359361#comment-14359361
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358074#comment-14358074
]
Aditya Auradkar commented on KAFKA-1546:
I'll write a short KIP on this and circul
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358063#comment-14358063
]
Jay Kreps commented on KAFKA-1546:
--
Well iiuc the wonderfulness of this feature is that i
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358058#comment-14358058
]
Joe Stein commented on KAFKA-1546:
--
we could also mark the JIRA as a bug instead of impro
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358054#comment-14358054
]
Joe Stein commented on KAFKA-1546:
--
if folks are going to read the KIP to understand for
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358039#comment-14358039
]
Jay Kreps commented on KAFKA-1546:
--
Personally I don't think it really needs a KIP, it su
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358017#comment-14358017
]
Joe Stein commented on KAFKA-1546:
--
Shouldn't we have a KIP for this? It seems like we ar
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357956#comment-14357956
]
Aditya A Auradkar commented on KAFKA-1546:
--
Updated reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357947#comment-14357947
]
Aditya A Auradkar commented on KAFKA-1546:
--
Created reviewboard https://reviews.a
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329143#comment-14329143
]
Jay Kreps commented on KAFKA-1546:
--
Yes, this was exactly what I was thinking...
> Autom
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328472#comment-14328472
]
Neha Narkhede commented on KAFKA-1546:
--
bq. If this isn't feasible, then I do think t
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328467#comment-14328467
]
Joel Koshy commented on KAFKA-1546:
---
No, we don't have any timestamp currently associate
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328465#comment-14328465
]
Joel Koshy commented on KAFKA-1546:
---
Re: your concern - yes that does seem to be valid.
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328427#comment-14328427
]
Aditya Auradkar commented on KAFKA-1546:
I agree we should model this in terms of
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328413#comment-14328413
]
Jiangjie Qin commented on KAFKA-1546:
-
I'm not sure if my concern is valid. If we have
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328318#comment-14328318
]
Neha Narkhede commented on KAFKA-1546:
--
bq. For example a replica could be catching
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328298#comment-14328298
]
Jay Kreps commented on KAFKA-1546:
--
Yeah that is true. I think we are in agreement that w
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328260#comment-14328260
]
Aditya Auradkar commented on KAFKA-1546:
I do have a concern about the heuristic.
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326773#comment-14326773
]
Aditya Auradkar commented on KAFKA-1546:
[~nmarasoi] I'm going to assign this to m
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313301#comment-14313301
]
Aditya Auradkar commented on KAFKA-1546:
[~nmarasoi] are you actively working on t
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068731#comment-14068731
]
Sriram Subramanian commented on KAFKA-1546:
---
the lagBegin does not persist acros
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068606#comment-14068606
]
Jun Rao commented on KAFKA-1546:
Yes, that works. So we will have to return enough info in
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068575#comment-14068575
]
Jay Kreps commented on KAFKA-1546:
--
I think I was being a little vague. What I was trying
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068209#comment-14068209
]
Jun Rao commented on KAFKA-1546:
Jay, I think what you proposed is nice and simple. I thin
[
https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065806#comment-14065806
]
Jay Kreps commented on KAFKA-1546:
--
I think this is actually a really important thing to
44 matches
Mail list logo
