[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281166#comment-14281166
]
Jun Rao commented on KAFKA-1723:
Actually committed the delta patch to 0.8.2 as well.
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277582#comment-14277582
]
Jun Rao commented on KAFKA-1723:
[~omkreddy], thanks for the delta patch. Since this is
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276944#comment-14276944
]
Vladimir Tretyakov commented on KAFKA-1723:
---
Hi, sorry for delay, but maybe
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276629#comment-14276629
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275651#comment-14275651
]
Manikumar Reddy commented on KAFKA-1723:
While going through metrics related
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275715#comment-14275715
]
Jun Rao commented on KAFKA-1723:
This is not a problem for now since all client provided
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270783#comment-14270783
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271758#comment-14271758
]
Jay Kreps commented on KAFKA-1723:
--
Yeah, I'm not really sure whether to just leave it or
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271663#comment-14271663
]
Manikumar Reddy commented on KAFKA-1723:
1. Submitted new patch with suggested
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271637#comment-14271637
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270163#comment-14270163
]
Jay Kreps commented on KAFKA-1723:
--
2. I think you are saying that sensor names are still
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269513#comment-14269513
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269585#comment-14269585
]
Manikumar Reddy commented on KAFKA-1723:
1. Added MetricName object and related
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269489#comment-14269489
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270066#comment-14270066
]
Jun Rao commented on KAFKA-1723:
Thanks for the patch.
1. Yes, I think this is needed.
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267407#comment-14267407
]
Manikumar Reddy commented on KAFKA-1723:
Thanks for the suggestion. will remove
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268121#comment-14268121
]
Jun Rao commented on KAFKA-1723:
Hi, Manikumar,
Thanks for working on this jira. Since we
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264870#comment-14264870
]
Jay Kreps commented on KAFKA-1723:
--
Makes sense.
I'd like to keep the metric data model
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263180#comment-14263180
]
Jay Kreps commented on KAFKA-1723:
--
The group/tags approach seems reasonable. I left some
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263211#comment-14263211
]
Jay Kreps commented on KAFKA-1723:
--
Also, I think we do need to add MetricName or
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262572#comment-14262572
]
Manikumar Reddy commented on KAFKA-1723:
Submitted a first level patch for jmx
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262555#comment-14262555
]
Manikumar Reddy commented on KAFKA-1723:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14200536#comment-14200536
]
Otis Gospodnetic commented on KAFKA-1723:
-
I don't follow this 100%, [~junrao].
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201138#comment-14201138
]
Jun Rao commented on KAFKA-1723:
[~otis], let me explain that a bit more. Historically, we
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198439#comment-14198439
]
Vladimir Tretyakov commented on KAFKA-1723:
---
Hi [~junrao],
{quote}
It uses a
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198502#comment-14198502
]
Jun Rao commented on KAFKA-1723:
Yes, we can make the mbean names in the new metrics
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198580#comment-14198580
]
Vladimir Tretyakov commented on KAFKA-1723:
---
Good news, thx [~junrao]
make the
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197319#comment-14197319
]
Otis Gospodnetic commented on KAFKA-1723:
-
Hm, I thought KAFKA-1481 would fix this
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197373#comment-14197373
]
Jun Rao commented on KAFKA-1723:
Otis,
The new producer doesn't use metrics-core. It uses
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179128#comment-14179128
]
Jun Rao commented on KAFKA-1723:
One way to address this issue is to change the jmx name
30 matches
Mail list logo
