[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621217#comment-14621217 ] Gwen Shapira commented on KAFKA-2187: - I think that per Apache, we need to acknowledge

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621228#comment-14621228 ] Ismael Juma commented on KAFKA-2187: It is mentioned in the script itself (near the

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621239#comment-14621239 ] Gwen Shapira commented on KAFKA-2187: - Sorry, I missed that. I think its good and I

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621243#comment-14621243 ] Gwen Shapira commented on KAFKA-2187: - One more thing: If I start a merge and cancel

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621257#comment-14621257 ] Ismael Juma commented on KAFKA-2187: Thanks for checking regarding the license. Good

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621260#comment-14621260 ] Ismael Juma commented on KAFKA-2187: In the meantime `git checkout -` should take you

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621387#comment-14621387 ] Ismael Juma commented on KAFKA-2187: OK, thank you. Introduce merge-kafka-pr.py

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621384#comment-14621384 ] Gwen Shapira commented on KAFKA-2187: - I accidentally committed this script as part of

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617319#comment-14617319 ] Ismael Juma commented on KAFKA-2187: Once we transition to the new way, we also need

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617311#comment-14617311 ] Ismael Juma commented on KAFKA-2187: [~nehanarkhede], I added a section to Patch

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569499#comment-14569499 ] Neha Narkhede commented on KAFKA-2187: -- [~ijuma] As I went through the patch again, I

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569592#comment-14569592 ] Ismael Juma commented on KAFKA-2187: Thanks [~nehanarkhede], I changed a couple of

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569579#comment-14569579 ] Ismael Juma commented on KAFKA-2187: Updated reviewboard

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567032#comment-14567032 ] Ismael Juma commented on KAFKA-2187: Sure, that was indeed my plan. Will do it soon.

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566884#comment-14566884 ] Neha Narkhede commented on KAFKA-2187: -- [~ijuma] This looks great. I can check it in,

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562478#comment-14562478 ] Ismael Juma commented on KAFKA-2187: [~nehanarkhede], please let me know if there's

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553237#comment-14553237 ] Ismael Juma commented on KAFKA-2187: Updated reviewboard

[jira] [Commented] (KAFKA-2187) Introduce merge-kafka-pr.py script

[ https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553226#comment-14553226 ] Ismael Juma commented on KAFKA-2187: Created reviewboard