[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779112#comment-15779112
]
ASF GitHub Bot commented on KAFKA-2391:
---
Github user pono closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947279#comment-14947279
]
Onur Karaman commented on KAFKA-2391:
-
As brought up earlier, blocking for request.timeout.ms time
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944640#comment-14944640
]
Ismael Juma commented on KAFKA-2391:
Note that this is related to KAFKA-1894.
> Blocking call such as
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944642#comment-14944642
]
Ismael Juma commented on KAFKA-2391:
Also note that `NetworkClient.poll` already takes
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945349#comment-14945349
]
Jiangjie Qin commented on KAFKA-2391:
-
[~ijuma] The problem of using request timeout for the public
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945385#comment-14945385
]
Ismael Juma commented on KAFKA-2391:
[~becket_qin], that's a fair point. The suggestion to use request
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708478#comment-14708478
]
Jay Kreps commented on KAFKA-2391:
--
Putting timeouts in the api encourages hard-coding
[
https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708710#comment-14708710
]
Mayuresh Gharat commented on KAFKA-2391:
[~jkreps] that is right. Was just