[jira] [Commented] (KAFKA-2397) leave group request

2015-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961597#comment-14961597 ] ASF GitHub Bot commented on KAFKA-2397: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-2397) leave group request

2015-10-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957718#comment-14957718 ] Guozhang Wang commented on KAFKA-2397: -- For consumer shutdown, in the ZK-based consumer we will

[jira] [Commented] (KAFKA-2397) leave group request

2015-10-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957550#comment-14957550 ] Jay Kreps commented on KAFKA-2397: -- Dunno if we closed the loop on the approach. [~onurkaraman] Yeah the

[jira] [Commented] (KAFKA-2397) leave group request

2015-10-14 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957784#comment-14957784 ] Onur Karaman commented on KAFKA-2397: - Cool. It sounds like we all generally agree on the explicit

[jira] [Commented] (KAFKA-2397) leave group request

2015-10-13 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955673#comment-14955673 ] Onur Karaman commented on KAFKA-2397: - My pull request had diverged again from trunk, so I force

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730633#comment-14730633 ] Onur Karaman commented on KAFKA-2397: - My pull request had diverged from trunk, so I force pushed a

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731052#comment-14731052 ] Jay Kreps commented on KAFKA-2397: -- Couple thoughts: 1. [~hachikuji] Does this need to be in the next

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731091#comment-14731091 ] Jay Kreps commented on KAFKA-2397: -- [~hachikuji] Makes sense. > leave group request >

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731073#comment-14731073 ] Jason Gustafson commented on KAFKA-2397: [~jkreps] Not having a way to properly leave the group is

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731373#comment-14731373 ] Jiangjie Qin commented on KAFKA-2397: - [~jkreps] using TCP close to signal disconnect does have

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-04 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731364#comment-14731364 ] Onur Karaman commented on KAFKA-2397: - Here's a summary of what I think each approach has to offer

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729769#comment-14729769 ] Jiangjie Qin commented on KAFKA-2397: - [~ewencp] [~hachikuji] Some thoughts on this. I agree with

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729800#comment-14729800 ] Jason Gustafson commented on KAFKA-2397: [~becket_qin] I'm not sure anyone was suggesting

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-02 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728410#comment-14728410 ] Ewen Cheslack-Postava commented on KAFKA-2397: -- [~hachikuji] My primary objection to that

[jira] [Commented] (KAFKA-2397) leave group request

2015-09-02 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727809#comment-14727809 ] Jason Gustafson commented on KAFKA-2397: Bumping this issue. One nice thing about the current

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-14 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696551#comment-14696551 ] Onur Karaman commented on KAFKA-2397: - Sooo... ship it?! leave group request

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696602#comment-14696602 ] Ewen Cheslack-Postava commented on KAFKA-2397: -- [~becket_qin] I was more

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696351#comment-14696351 ] Jason Gustafson commented on KAFKA-2397: [~ewencp] The only case I can come up

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696327#comment-14696327 ] Ewen Cheslack-Postava commented on KAFKA-2397: -- Can we be more concrete about

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696334#comment-14696334 ] Jiangjie Qin commented on KAFKA-2397: - [~ewencp] Are you saying that the coordinator

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-06 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660269#comment-14660269 ] Jason Gustafson commented on KAFKA-2397: [~jkreps] Yeah, TCP is pretty resilient

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660279#comment-14660279 ] Jay Kreps commented on KAFKA-2397: -- [~guozhang] Basically session would be the concept

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659525#comment-14659525 ] Guozhang Wang commented on KAFKA-2397: -- [~jkreps] I need to look into the session

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659470#comment-14659470 ] Jay Kreps commented on KAFKA-2397: -- [~guozhang] I haven't thought this through but here

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659158#comment-14659158 ] Guozhang Wang commented on KAFKA-2397: -- I once considered letting KafkaApis to handle

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659185#comment-14659185 ] Gwen Shapira commented on KAFKA-2397: - No, SocketServer may be aware of host:port of

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-05 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659275#comment-14659275 ] Jason Gustafson commented on KAFKA-2397: [~jkreps] I think the disconnect approach

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652686#comment-14652686 ] Jay Kreps commented on KAFKA-2397: -- Nice summary [~onurkaraman]. I agree that adding a

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652231#comment-14652231 ] Jiangjie Qin commented on KAFKA-2397: - I would prefer extending heartbeat to indicate

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652198#comment-14652198 ] Jason Gustafson commented on KAFKA-2397: [~onurkaraman] I like this idea. Wouldn't

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652386#comment-14652386 ] Onur Karaman commented on KAFKA-2397: - Hey everyone. There's a difference between the

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650693#comment-14650693 ] ASF GitHub Bot commented on KAFKA-2397: --- GitHub user onurkaraman opened a pull