[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961597#comment-14961597
]
ASF GitHub Bot commented on KAFKA-2397:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957718#comment-14957718
]
Guozhang Wang commented on KAFKA-2397:
--
For consumer shutdown, in the ZK-based consumer we will
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957550#comment-14957550
]
Jay Kreps commented on KAFKA-2397:
--
Dunno if we closed the loop on the approach.
[~onurkaraman] Yeah the
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957784#comment-14957784
]
Onur Karaman commented on KAFKA-2397:
-
Cool. It sounds like we all generally agree on the explicit
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955673#comment-14955673
]
Onur Karaman commented on KAFKA-2397:
-
My pull request had diverged again from trunk, so I force
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730633#comment-14730633
]
Onur Karaman commented on KAFKA-2397:
-
My pull request had diverged from trunk, so I force pushed a
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731052#comment-14731052
]
Jay Kreps commented on KAFKA-2397:
--
Couple thoughts:
1. [~hachikuji] Does this need to be in the next
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731091#comment-14731091
]
Jay Kreps commented on KAFKA-2397:
--
[~hachikuji] Makes sense.
> leave group request
>
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731073#comment-14731073
]
Jason Gustafson commented on KAFKA-2397:
[~jkreps] Not having a way to properly leave the group is
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731373#comment-14731373
]
Jiangjie Qin commented on KAFKA-2397:
-
[~jkreps] using TCP close to signal disconnect does have
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731364#comment-14731364
]
Onur Karaman commented on KAFKA-2397:
-
Here's a summary of what I think each approach has to offer
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729769#comment-14729769
]
Jiangjie Qin commented on KAFKA-2397:
-
[~ewencp] [~hachikuji] Some thoughts on this. I agree with
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729800#comment-14729800
]
Jason Gustafson commented on KAFKA-2397:
[~becket_qin] I'm not sure anyone was suggesting
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728410#comment-14728410
]
Ewen Cheslack-Postava commented on KAFKA-2397:
--
[~hachikuji] My primary objection to that
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727809#comment-14727809
]
Jason Gustafson commented on KAFKA-2397:
Bumping this issue. One nice thing about the current
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696551#comment-14696551
]
Onur Karaman commented on KAFKA-2397:
-
Sooo... ship it?!
leave group request
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696602#comment-14696602
]
Ewen Cheslack-Postava commented on KAFKA-2397:
--
[~becket_qin] I was more
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696351#comment-14696351
]
Jason Gustafson commented on KAFKA-2397:
[~ewencp] The only case I can come up
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696327#comment-14696327
]
Ewen Cheslack-Postava commented on KAFKA-2397:
--
Can we be more concrete about
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696334#comment-14696334
]
Jiangjie Qin commented on KAFKA-2397:
-
[~ewencp] Are you saying that the coordinator
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660269#comment-14660269
]
Jason Gustafson commented on KAFKA-2397:
[~jkreps] Yeah, TCP is pretty resilient
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660279#comment-14660279
]
Jay Kreps commented on KAFKA-2397:
--
[~guozhang] Basically session would be the concept
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659525#comment-14659525
]
Guozhang Wang commented on KAFKA-2397:
--
[~jkreps] I need to look into the session
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659470#comment-14659470
]
Jay Kreps commented on KAFKA-2397:
--
[~guozhang] I haven't thought this through but here
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659158#comment-14659158
]
Guozhang Wang commented on KAFKA-2397:
--
I once considered letting KafkaApis to handle
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659185#comment-14659185
]
Gwen Shapira commented on KAFKA-2397:
-
No, SocketServer may be aware of host:port of
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659275#comment-14659275
]
Jason Gustafson commented on KAFKA-2397:
[~jkreps] I think the disconnect approach
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652686#comment-14652686
]
Jay Kreps commented on KAFKA-2397:
--
Nice summary [~onurkaraman].
I agree that adding a
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652231#comment-14652231
]
Jiangjie Qin commented on KAFKA-2397:
-
I would prefer extending heartbeat to indicate
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652198#comment-14652198
]
Jason Gustafson commented on KAFKA-2397:
[~onurkaraman] I like this idea. Wouldn't
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652386#comment-14652386
]
Onur Karaman commented on KAFKA-2397:
-
Hey everyone.
There's a difference between the
[
https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650693#comment-14650693
]
ASF GitHub Bot commented on KAFKA-2397:
---
GitHub user onurkaraman opened a pull
32 matches
Mail list logo