[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960994#comment-14960994 ] ASF GitHub Bot commented on KAFKA-2419: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958698#comment-14958698 ] Ismael Juma commented on KAFKA-2419: [~aauradkar] [~jjkoshy] We are creating one thread per `Metrics`

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958978#comment-14958978 ] Ismael Juma commented on KAFKA-2419: [~aauradkar] Thanks for submitting a fix for `ExpireSensorTask`

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959017#comment-14959017 ] Jun Rao commented on KAFKA-2419: It's more important to garbage collect old sensors on the broker than on

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958962#comment-14958962 ] Aditya Auradkar commented on KAFKA-2419: [~ijuma] - We create only a single metrics instance for

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960131#comment-14960131 ] ASF GitHub Bot commented on KAFKA-2419: --- GitHub user auradkar opened a pull request:

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959543#comment-14959543 ] Jay Kreps commented on KAFKA-2419: -- It would be preferable to not need additional threads--we put

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959588#comment-14959588 ] Aditya Auradkar commented on KAFKA-2419: I agree it would be nice to not need a tick thread.. but

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959522#comment-14959522 ] Jun Rao commented on KAFKA-2419: Yes, I was suggesting using a single expiration value at the metrics

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959484#comment-14959484 ] Aditya Auradkar commented on KAFKA-2419: [~junrao] - That is indeed the current implementation

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959457#comment-14959457 ] Jun Rao commented on KAFKA-2419: [~aauradkar], I thought the implementation will be just to schedule the

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947488#comment-14947488 ] ASF GitHub Bot commented on KAFKA-2419: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903731#comment-14903731 ] ASF GitHub Bot commented on KAFKA-2419: --- GitHub user auradkar opened a pull request:

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14875986#comment-14875986 ] Joel Koshy commented on KAFKA-2419: --- However, we should think through the effect of doing this. i.e.,

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804893#comment-14804893 ] Joel Koshy commented on KAFKA-2419: --- Re: the options in

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739324#comment-14739324 ] Aditya Auradkar commented on KAFKA-2419: Thanks [~ijuma] I'll take a look today. If I indeed can

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737756#comment-14737756 ] Aditya Auradkar commented on KAFKA-2419: [~junrao][~jjkoshy] We have a couple of ways to solve

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737497#comment-14737497 ] Aditya Auradkar commented on KAFKA-2419: [~junrao] I'm working on this now. Shall submit a patch

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724422#comment-14724422 ] Jun Rao commented on KAFKA-2419: [~aauradkar], are you working on this? We probably need to have this