[ https://issues.apache.org/jira/browse/KAFKA-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965809#comment-14965809 ]
ASF GitHub Bot commented on KAFKA-2617: --------------------------------------- GitHub user Mszak opened a pull request: https://github.com/apache/kafka/pull/338 KAFKA-2617: Move protocol field default values to Protocol. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Mszak/kafka kafka-2617-move-default-values Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #338 ---- commit a99c5dff41aa548303c4f6dec586cb22e3b70a59 Author: Jakub Nowak <jakub.nowa...@interia.pl> Date: 2015-10-20T21:11:30Z Move protocol field default values to Protocol. ---- > Move protocol field default values to Protocol > ---------------------------------------------- > > Key: KAFKA-2617 > URL: https://issues.apache.org/jira/browse/KAFKA-2617 > Project: Kafka > Issue Type: Bug > Reporter: Guozhang Wang > Assignee: Jakub Nowak > Labels: newbie > Fix For: 0.9.0.0 > > > Right now the default values are scattered in the Request / Response classes, > and some duplicates already exists like JoinGroupRequest.UNKNOWN_CONSUMER_ID > and OffsetCommitRequest.DEFAULT_CONSUMER_ID. We would like to move all > default values into org.apache.kafka.common.protocol.Protocol since > org.apache.kafka.common.requests depends on org.apache.kafka.common.protocol > anyways. -- This message was sent by Atlassian JIRA (v6.3.4#6332)