[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997165#comment-14997165
]
ASF GitHub Bot commented on KAFKA-2674:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997155#comment-14997155
]
Jason Gustafson commented on KAFKA-2674:
[~guozhang] [~becket_qin] I added a commi
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997148#comment-14997148
]
ASF GitHub Bot commented on KAFKA-2674:
---
GitHub user hachikuji opened a pull request
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986541#comment-14986541
]
Jiangjie Qin commented on KAFKA-2674:
-
Yes, I agree documenting it clearly is probably
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986470#comment-14986470
]
Jason Gustafson commented on KAFKA-2674:
[~guozhang] [~becket_qin] Since none of t
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980737#comment-14980737
]
Jiangjie Qin commented on KAFKA-2674:
-
[~hachikuji] I am wondering do we want to avoid
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979819#comment-14979819
]
Jason Gustafson commented on KAFKA-2674:
[~guozhang] In the context of rebalancing
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979433#comment-14979433
]
Jay Kreps commented on KAFKA-2674:
--
[~hachikuji] I don't have a ton to add. I think I add
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977457#comment-14977457
]
Jiangjie Qin commented on KAFKA-2674:
-
I don't have a strong opinion on this. I agree
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975020#comment-14975020
]
Guozhang Wang commented on KAFKA-2674:
--
Personally I prefer the old function names si
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974770#comment-14974770
]
Jason Gustafson commented on KAFKA-2674:
[~becket_qin] [~guozhang] What would you
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968467#comment-14968467
]
Jiangjie Qin commented on KAFKA-2674:
-
[~hachikuji] I agree the name is a little misle
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968420#comment-14968420
]
Jason Gustafson commented on KAFKA-2674:
I agree with [~becket_qin] that this is p
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968350#comment-14968350
]
Jiangjie Qin commented on KAFKA-2674:
-
[~guozhang] That is a valid concern, I haven't
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967638#comment-14967638
]
Guozhang Wang commented on KAFKA-2674:
--
This is a good point, especially if the user
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966003#comment-14966003
]
Jiangjie Qin commented on KAFKA-2674:
-
[~guozhang] The original reason we add consumer
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965935#comment-14965935
]
Jason Gustafson commented on KAFKA-2674:
Since LeaveGroup will cause a group rebal
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965913#comment-14965913
]
Guozhang Wang commented on KAFKA-2674:
--
Today we are already calling ```commitOffsetS
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965865#comment-14965865
]
Jiangjie Qin commented on KAFKA-2674:
-
I think it would be clearer if rebalance callba
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965803#comment-14965803
]
Jason Gustafson commented on KAFKA-2674:
[~becket_qin] I think the only problem wi
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965782#comment-14965782
]
Jiangjie Qin commented on KAFKA-2674:
-
[~hachikuji] I am reviewing KAFKA-2464 and also
[
https://issues.apache.org/jira/browse/KAFKA-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965532#comment-14965532
]
Jason Gustafson commented on KAFKA-2674:
[~onurkaraman] Maybe this issue can be ad
22 matches
Mail list logo