[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386504#comment-15386504 ] ASF GitHub Bot commented on KAFKA-3915: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385866#comment-15385866 ] ASF GitHub Bot commented on KAFKA-3915: --- GitHub user ijuma opened a pull request:

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-07-19 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384060#comment-15384060 ] Ismael Juma commented on KAFKA-3915: [~twbecker], the issue is that consumers might no

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-07-19 Thread Tommy Becker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384017#comment-15384017 ] Tommy Becker commented on KAFKA-3915: - [~junrao] Yes I understand the max message size

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-07-18 Thread James Cheng (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383610#comment-15383610 ] James Cheng commented on KAFKA-3915: We just saw this in one of our brokers as well. W

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357996#comment-15357996 ] Jun Rao commented on KAFKA-3915: Yes, we could choose to only keep the old message format

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-29 Thread Tommy Becker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355150#comment-15355150 ] Tommy Becker commented on KAFKA-3915: - Actually, I don't think this is true. The buffe

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-29 Thread Tommy Becker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355135#comment-15355135 ] Tommy Becker commented on KAFKA-3915: - Should a change to the default maxMessageSize b

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354183#comment-15354183 ] Jun Rao commented on KAFKA-3915: The writeBuffer is set to maxMessageSize. We can't really

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-28 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353422#comment-15353422 ] Ismael Juma commented on KAFKA-3915: "Another point is that in the future, when copyin

[jira] [Commented] (KAFKA-3915) LogCleaner IO buffers do not account for potential size difference due to message format change

2016-06-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353396#comment-15353396 ] Jun Rao commented on KAFKA-3915: [~twbecker], thanks for reporting this. Keeping the old