[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-29 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385999#comment-14385999 ] Neha Narkhede commented on KAFKA-527: - [~guozhang] +1. Will be great to re-run the test

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382872#comment-14382872 ] Guozhang Wang commented on KAFKA-527: - Both patches have been checked in, closing this

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382880#comment-14382880 ] Jay Kreps commented on KAFKA-527: - Do we have any kind of before/after performance

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-25 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380547#comment-14380547 ] Yasuhiro Matsuda commented on KAFKA-527: Updated reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380657#comment-14380657 ] Jun Rao commented on KAFKA-527: --- [~ymatsuda], thanks for the patch. +1 and committed to

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380693#comment-14380693 ] Guozhang Wang commented on KAFKA-527: - Updated reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380706#comment-14380706 ] Jay Kreps commented on KAFKA-527: - Yeah it would be great to get the [~guozhang]'s patch in

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-19 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370703#comment-14370703 ] Yasuhiro Matsuda commented on KAFKA-527: Updated reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-16 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364085#comment-14364085 ] Yasuhiro Matsuda commented on KAFKA-527: Updated reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355133#comment-14355133 ] Guozhang Wang commented on KAFKA-527: - Hi Yasuhiro, I thought for compressed writes,

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1435#comment-1435 ] Neha Narkhede commented on KAFKA-527: - bq. I think in the end we will deprecate

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-08 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352227#comment-14352227 ] Jay Kreps commented on KAFKA-527: - The clients already use MemoryRecords, so 0.8.2 and

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352230#comment-14352230 ] Neha Narkhede commented on KAFKA-527: - Agree with the long term plan. Definitely makes

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352290#comment-14352290 ] Yasuhiro Matsuda commented on KAFKA-527: This patch is mainly aimed at #1 above If

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351177#comment-14351177 ] Guozhang Wang commented on KAFKA-527: - Thanks for the patch, this is very promising.

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351180#comment-14351180 ] Guozhang Wang commented on KAFKA-527: - Created reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-04 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347441#comment-14347441 ] Yasuhiro Matsuda commented on KAFKA-527: Created reviewboard

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2015-03-04 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347478#comment-14347478 ] Yasuhiro Matsuda commented on KAFKA-527: This patch introduces

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2013-10-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784463#comment-13784463 ] Guozhang Wang commented on KAFKA-527: - If we do not want to use the attribute byte and

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2013-08-15 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741294#comment-13741294 ] Guozhang Wang commented on KAFKA-527: - One alternative approach would be like this:

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2013-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728575#comment-13728575 ] Jay Kreps commented on KAFKA-527: - The general idea of the refactoring would be to allow

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

2013-08-02 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728452#comment-13728452 ] Jay Kreps commented on KAFKA-527: - To test performance checkout trunk and do ./sbt package