[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035447#comment-16035447 ] ASF GitHub Bot commented on KAFKA-5322: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-06-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034177#comment-16034177 ] ASF GitHub Bot commented on KAFKA-5322: --- GitHub user apurvam opened a pull request:

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-06-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033064#comment-16033064 ] Jun Rao commented on KAFKA-5322: Option 2 sounds good to me too. > Resolve AddPartitions

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-06-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032653#comment-16032653 ] Ismael Juma commented on KAFKA-5322: Btw, because this changes the protocol, it would

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-05-31 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032502#comment-16032502 ] Ismael Juma commented on KAFKA-5322: I prefer option 2 as well. > Resolve AddPartitio

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-05-31 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032485#comment-16032485 ] Jason Gustafson commented on KAFKA-5322: [~guozhang] That sounds good to me. I'll

[jira] [Commented] (KAFKA-5322) Resolve AddPartitions response error code inconsistency

2017-05-26 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026481#comment-16026481 ] Guozhang Wang commented on KAFKA-5322: -- [~hachikuji] I'd prefer option 2, to still ha