[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600218#comment-13600218 ] Jun Rao commented on KAFKA-554: --- For debugging purpose, is it useful to be able to get the

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597368#comment-13597368 ] Jun Rao commented on KAFKA-554: --- For 4, you have to do the following: Instead of using ( for

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597385#comment-13597385 ] Neha Narkhede commented on KAFKA-554: - Json.scala - It seems like the map and sequence

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597661#comment-13597661 ] Neha Narkhede commented on KAFKA-554: - +1 on patch v4 Move all

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-06 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595090#comment-13595090 ] Neha Narkhede commented on KAFKA-554: - I'm a little late to this review and seems like

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592883#comment-13592883 ] Jay Kreps commented on KAFKA-554: - Yeah I thought about json vs properties. The advantage i

[jira] [Commented] (KAFKA-554) Move all per-topic configuration into ZK and add to the CreateTopicCommand

2013-03-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591984#comment-13591984 ] Jun Rao commented on KAFKA-554: --- Thanks for patch v1. Looks good overall. Some comments: 1.