[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587545#comment-13587545
]
Neha Narkhede commented on KAFKA-671:
-
+1. If others don't have any other input, I will
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586305#comment-13586305
]
Neha Narkhede commented on KAFKA-671:
-
I see, in that case, I still don't see the use o
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586289#comment-13586289
]
Sriram Subramanian commented on KAFKA-671:
--
We want to print the topicPartition an
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586282#comment-13586282
]
Neha Narkhede commented on KAFKA-671:
-
Looks good overall. Just one comment -
In the t
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585203#comment-13585203
]
Jun Rao commented on KAFKA-671:
---
Patch v4 doesn't apply. 0.8 has moved since the patch is upl
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571360#comment-13571360
]
Jay Kreps commented on KAFKA-671:
-
I think hacking requestObj is fine as an intermediate st
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571088#comment-13571088
]
Sriram Subramanian commented on KAFKA-671:
--
Jay - are you fine with checking this
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567933#comment-13567933
]
Sriram Subramanian commented on KAFKA-671:
--
KAFKA-745 is tracking the cleanup of R
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566240#comment-13566240
]
Jay Kreps commented on KAFKA-671:
-
Okay let's sync up. I think requestObj is the devil. :-)
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566222#comment-13566222
]
Sriram Subramanian commented on KAFKA-671:
--
The issue is that even if we pass only
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566188#comment-13566188
]
Jay Kreps commented on KAFKA-671:
-
Took a look at this. Looks reasonable.
Other atrocities
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565980#comment-13565980
]
Sriram Subramanian commented on KAFKA-671:
--
1. You can ignore the changes in syste
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565679#comment-13565679
]
Neha Narkhede commented on KAFKA-671:
-
Thanks for the v2 patch, few review comments -
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558969#comment-13558969
]
Neha Narkhede commented on KAFKA-671:
-
Thinking about this a little more, the real prob
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558946#comment-13558946
]
Neha Narkhede commented on KAFKA-671:
-
Nullifying the request object seems like a bigge
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558462#comment-13558462
]
Sriram Subramanian commented on KAFKA-671:
--
I think to do this right we should lim
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558448#comment-13558448
]
Jun Rao commented on KAFKA-671:
---
Thinking about this a bit more. There is another approach. I
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558420#comment-13558420
]
Jun Rao commented on KAFKA-671:
---
Thanks for the patch. I agree with Neha that ProducerRequest
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554178#comment-13554178
]
Sriram Subramanian commented on KAFKA-671:
--
2. I am not sure if it is an issue in
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554172#comment-13554172
]
Neha Narkhede commented on KAFKA-671:
-
2. You maybe right. However, given that you set
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554158#comment-13554158
]
Sriram Subramanian commented on KAFKA-671:
--
2. I don't think so since DelayedProdu
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554142#comment-13554142
]
Neha Narkhede commented on KAFKA-671:
-
Overall, the changes look good. Minor suggestion
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538606#comment-13538606
]
Jay Kreps commented on KAFKA-671:
-
I am concerned this may be a blocker for production usag
23 matches
Mail list logo
