Anna Povzner created KAFKA-8837:
-----------------------------------

             Summary: KafkaMetricReporterClusterIdTest may not shutdown 
ZooKeeperTestHarness
                 Key: KAFKA-8837
                 URL: https://issues.apache.org/jira/browse/KAFKA-8837
             Project: Kafka
          Issue Type: Bug
          Components: core
            Reporter: Anna Povzner
            Assignee: Anastasia Vela


@After method in KafkaMetricReporterClusterIdTest calls  
`TestUtils.verifyNonDaemonThreadsStatus(this.getClass.getName)` before it calls 
tearDown on ZooKeeperTestHarness (which shut downs ZK and zk client). If 
verifyNonDaemonThreadsStatus asserts, the rest of the resources will not get 
cleaned up.

We should move `TestUtils.verifyNonDaemonThreadsStatus(this.getClass.getName)` 
to the end of `tearDown()`. However, would also be good to prevent people using 
this method in tear down similarly in the future. Maybe just adding a comment 
would help here.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to