[ https://issues.apache.org/jira/browse/KAFKA-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chia-Ping Tsai resolved KAFKA-16562. ------------------------------------ Resolution: Invalid sorry this jira is for yunikorn ... > Install the ginkgo to tools folder > ---------------------------------- > > Key: KAFKA-16562 > URL: https://issues.apache.org/jira/browse/KAFKA-16562 > Project: Kafka > Issue Type: Improvement > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Major > > https://github.com/apache/yunikorn-k8shim/blob/master/scripts/run-e2e-tests.sh#L111 > `run-e2e-tests.sh` install the ginkgo in the `GOBIN` folder. However, our > `make e2e_test` assumes all tools are installed at yunikorn-k8shim/tools, and > hence we can see `Command 'ginkgo' not found` error if we don't export the > `GOBIN`. > It seems to me this jira should includes following changes. > 1. move the ginkgo installation from run-e2e-tests to makefile. Let `make > tools` install all required tools > 2. makefile should install ginkgo to tools folder. the tools folder is added > to PATH, so user can run e2e more easily. -- This message was sent by Atlassian Jira (v8.20.10#820010)