Re: Adding @NotNull annotation to public APIs, KIP needed or not?

2021-06-14 Thread Matthias J. Sax
Personally, I think it might make sense to use annotations. And I agree, that we should have proper null-checks in place anyway, so existing code should not break. But I don't feel strong about it either -- not sure if some people might have concerns? In the end, a KIP sound appropriate though. J

Adding @NotNull annotation to public APIs, KIP needed or not?

2021-06-04 Thread Matthew de Detrich
Hello everyone, I was thinking of doing a PR which involved adding @NotNull annotations to various Kafka API's. Afaik the @NotNull annotation doesn't break binary compatibility however it can break source compatibility. The point is that even though using @NotNull can break source compatibility,