Re: Exceptions on trunk

2015-04-13 Thread Guozhang Wang
My bad on 1), fixing it right now. On Sun, Apr 12, 2015 at 8:06 PM, Jun Rao wrote: > For 1, the issue seems to be that we try to get metadata using the offset > field. Filed KAFKA-2117. > > Thanks, > > Jun > > On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps wrote: > > > I see the following issues on

Re: Exceptions on trunk

2015-04-12 Thread Jun Rao
For 1, the issue seems to be that we try to get metadata using the offset field. Filed KAFKA-2117. Thanks, Jun On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps wrote: > I see the following issues on trunk when doing almost anything: > > > 1. Offset manager: it looks like this code has never been run

Re: Exceptions on trunk

2015-04-12 Thread Gwen Shapira
The second error is a result of KAFKA-2044 - we moved few Requests out of RequestKeys to the newer ApiKeys, but didn't update the metrics code. The only requests that moved were HeartBeat and JoinGroup, which are part of the new consumer. I think it will be a good idea to add tests that use new co

Re: Exceptions on trunk

2015-04-12 Thread Jay Kreps
Also, I just want to remind people that everything in kafka.network should really be a standalone network server, so that code block in RequestChannel that hard codes stuff about followers is really wrong. -Jay On Sun, Apr 12, 2015 at 1:12 PM, Jay Kreps wrote: > I see the following issues on tr

Exceptions on trunk

2015-04-12 Thread Jay Kreps
I see the following issues on trunk when doing almost anything: 1. Offset manager: it looks like this code has never been run, there is a type that tries to read the offset as a string. java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.String at kafka.server.OffsetManager