Re: KAFKA-15571 Review

2023-10-10 Thread Levani Kokhreidze
Hi Bruno, Thanks for taking a look. I’ve added a test as well. Is it fair to say that we can expect 3.5.2 release with this fix? I can cherry pick the changes into the 3.5 branch. Best, Levani > On 10. Oct 2023, at 16:35, Bruno Cadonna wrote: > > Hi Levani, > > I think you found a bug and

Re: KAFKA-15571 Review

2023-10-10 Thread Bruno Cadonna
Hi Levani, I think you found a bug and you are looking at the right place! I commented on the PR. Best, Bruno On 10/10/23 3:02 PM, Levani Kokhreidze wrote: Hello, We’ve been looking at a https://issues.apache.org/jira/browse/KAFKA-10575 but seems implementation has a bug and user defined

KAFKA-15571 Review

2023-10-10 Thread Levani Kokhreidze
Hello, We’ve been looking at a https://issues.apache.org/jira/browse/KAFKA-10575 but seems implementation has a bug and user defined `StateRestoreListener#onRestoreSuspended` is not called because DelegatingStateRestoreListener was not updated. Here’s the PR that fixes it: