RE: Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi whsoul, No further comments from me, and sorry for the delay. This looks good! Feel free to open a vote thread and I can kick things off with a +1. Cheers, Chris

Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hello Chris, Long time no feed back about this, do I have any work left to do to proceed with discuss and vote? I will waiting for your guide, thanks, always whsoul 2022년 6월 14일 (화) 오후 9:29, gyejun choi 님이 작성: > Hi Chris > > I updated KIP document > >

Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi Chris I updated KIP document https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+Struct%28or+Map%29+with+Regex ) about discussion and changes before, and commited some code according to your review.

Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi whsoul, Would you mind updating the KIP document ( https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+Struct%28or+Map%29+with+Regex) with all of these changes? We tend to discuss and vote on what's included in the Wiki as our source of

Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi Chris, I applied some code fix according your second reviews. https://github.com/apache/kafka/pull/12219/commits/f673ea2eae0d907502e44c0ecd53b616386627bf 1. [applied] changed name as ParseStructByRegex 2. [applied] throw DataException, when a line that the SMT sees doesn't match the

Re: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi whsoul, Thanks for the updates. I have a few more thoughts but this is looking pretty good: 1. The name "ToStructByRegexTransform" is a little unwieldy. What do you think about something shorter like ParseStruct, ParseRegex, or ParseStructByRegex? 2. What happens if a line that the SMT sees

RE: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi Chris, Thank you for your positive feed back, And sorry about late reply ( I didn’t recognize your reply email… TT ) And I update KIP and PR with your review https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+Struct%28or+Map%29+with+Regex

RE: Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi Chris, Thank you for your positive feed back, And sorry about late reply ( I didn’t recognize your reply email… TT ) And I update KIP and PR with your review https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+Struct%28or+Map%29+with+Regex

Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi whsoul, Thanks for the KIP. The two use cases you identified seem quite appealing, especially the first one: parsing structured log messages. Here are my initial thoughts on the proposed design: 1. I wonder if it's necessary to include support for type casting with this SMT. We already have

Re: KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

is there someone who any feed back about this? 2020년 10월 23일 (금) 오후 2:56, gyejun choi 님이 작성: > Hi, > > I've opened KIP-678 which is intended to provide a new SMT in Kafka Connect. > I'd be grateful for any >

KIP 678: New Kafka Connect SMT for plainText => Struct(or Map) with Regex

Hi, I've opened KIP-678 which is intended to provide a new SMT in Kafka Connect. I'd be grateful for any feedback:https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+Struct%28or+Map%29+with+Regex== thanks, whsoul