Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-16 Thread Vahid S Hashemian
This KIP has passed with 3 binding and 8 non-binding +1 votes. Binding votes: * Jason Gustafson * Gwen Shapira * Rajini Sivaram Non-binding votes: * Stanislav Kozlovski * Kamal Chandraprakash * Mickael Maison * Ted Yu * Manikumar * Colin McCabe * Satish Duggana * Viktor Somogyi Thanks to all who

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-16 Thread Viktor Somogyi
+1 (non-binding), thanks for this Vahid! On Thu, Aug 16, 2018 at 10:39 AM Rajini Sivaram wrote: > Hi Vahid, Thanks for the KIP! > > +1 (binding) > > Regards, > > Rajini > > On Tue, Aug 14, 2018 at 12:18 AM, Satish Duggana > > wrote: > > > +1 (non binding) > > Thanks Vahid, > > > > On Tue, Aug 1

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-16 Thread Rajini Sivaram
Hi Vahid, Thanks for the KIP! +1 (binding) Regards, Rajini On Tue, Aug 14, 2018 at 12:18 AM, Satish Duggana wrote: > +1 (non binding) > Thanks Vahid, > > On Tue, Aug 14, 2018 at 2:22 AM, Gwen Shapira wrote: > > > +1 (binding) > > > > On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < > > v

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-13 Thread Satish Duggana
+1 (non binding) Thanks Vahid, On Tue, Aug 14, 2018 at 2:22 AM, Gwen Shapira wrote: > +1 (binding) > > On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > Hi all, > > > > I'd like to start a vote on KIP-289 to modify the default group id of > > KafkaCon

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-13 Thread Gwen Shapira
+1 (binding) On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Hi all, > > I'd like to start a vote on KIP-289 to modify the default group id of > KafkaConsumer. > The KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 289%3A+Improve+the+default

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-13 Thread Vahid S Hashemian
Thanks Colin, just updated the table. I had skipped them because they were listed in the earlier table in the KIP. --Vahid From: Colin McCabe To: dev@kafka.apache.org Date: 08/13/2018 09:45 AM Subject:Re: [VOTE] KIP-289: Improve the default group id behavior in

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-13 Thread Colin McCabe
+1 (non-binding). Thanks, Vahid! One last question: can you fill in the behavior for the group.id="" case, in the table following "This is how these two group ids will work". It would be helpful to have a description of this behavior in the KIP for documentation purposes. cheers, Colin On T

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-08 Thread Manikumar
+1 (non-binding). Thanks for the KIP. On Wed, Aug 8, 2018 at 7:36 PM Ted Yu wrote: > +1 > > On Wed, Aug 8, 2018 at 4:09 AM Mickael Maison > wrote: > > > +1 (non-binding) > > Thanks Vahid > > On Wed, Aug 8, 2018 at 11:26 AM Kamal Chandraprakash > > wrote: > > > > > > +1 (non-binding) > > > > >

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-08 Thread Ted Yu
+1 On Wed, Aug 8, 2018 at 4:09 AM Mickael Maison wrote: > +1 (non-binding) > Thanks Vahid > On Wed, Aug 8, 2018 at 11:26 AM Kamal Chandraprakash > wrote: > > > > +1 (non-binding) > > > > Thanks for the KIP. > > > > On Wed, Aug 8, 2018 at 3:11 PM Stanislav Kozlovski < > stanis...@confluent.io> >

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-08 Thread Mickael Maison
+1 (non-binding) Thanks Vahid On Wed, Aug 8, 2018 at 11:26 AM Kamal Chandraprakash wrote: > > +1 (non-binding) > > Thanks for the KIP. > > On Wed, Aug 8, 2018 at 3:11 PM Stanislav Kozlovski > wrote: > > > +1 (non-binding) > > Thanks! > > > > On Tue, Aug 7, 2018 at 11:47 PM Jason Gustafson > > wr

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-08 Thread Kamal Chandraprakash
+1 (non-binding) Thanks for the KIP. On Wed, Aug 8, 2018 at 3:11 PM Stanislav Kozlovski wrote: > +1 (non-binding) > Thanks! > > On Tue, Aug 7, 2018 at 11:47 PM Jason Gustafson > wrote: > > > +1 Thanks Vahid. > > > > On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < > > vahidhashem...@us.ibm

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-08 Thread Stanislav Kozlovski
+1 (non-binding) Thanks! On Tue, Aug 7, 2018 at 11:47 PM Jason Gustafson wrote: > +1 Thanks Vahid. > > On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > Hi all, > > > > I'd like to start a vote on KIP-289 to modify the default group id of > > KafkaCon

Re: [VOTE] KIP-289: Improve the default group id behavior in KafkaConsumer

2018-08-07 Thread Jason Gustafson
+1 Thanks Vahid. On Tue, Aug 7, 2018 at 11:14 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Hi all, > > I'd like to start a vote on KIP-289 to modify the default group id of > KafkaConsumer. > The KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 289%3A+Improve+the+def