---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24676/#review57235
---
Very nicely done.
These are all minor comments - all but one
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24676/#review57178
---
Thanks for the patch. +1 after addressing a couple of more minor
On Oct. 16, 2014, 1:29 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/KafkaApis.scala, line 167
https://reviews.apache.org/r/24676/diff/9/?file=720184#file720184line167
Should replica manager be offset manager?
This is replica manager actually, when it tries to write the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24676/#review56843
---
Thanks for the patch. Looks good to me. I only have some minor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24676/
---
(Updated Oct. 14, 2014, 2:42 a.m.)
Review request for kafka.
Summary
