Re: Review Request 36346: fix heartbeat to allow offset commits during PreparingRebalance

2015-07-09 Thread Onur Karaman
> On July 9, 2015, 4:58 p.m., Ewen Cheslack-Postava wrote: > > Just FYI, this was also noticed in the patch for KAFKA-2123 (which is > > moving quite a bit of code around). The solution was a bit different (the > > condition is different and keeps the existing generation ID increment > > locat

Re: Review Request 36346: fix heartbeat to allow offset commits during PreparingRebalance

2015-07-09 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36346/#review91118 --- Just FYI, this was also noticed in the patch for KAFKA-2123 (which i

Re: Review Request 36346: fix heartbeat to allow offset commits during PreparingRebalance

2015-07-09 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36346/ --- (Updated July 9, 2015, 9:42 a.m.) Review request for kafka. Bugs: KAFKA-1740