Re: Troubles with compressed message set

2013-01-30 Thread David Arthur
On 1/30/13 4:17 PM, Jay Kreps wrote: Ah, yes, the decision since we were making a breaking change to the protocol to just reset all the versions to 0. Excellent, I shall purge my 0.7x compatible code at once :) But if you are trying to handle both cases from the same code that will be hard. -

Re: Troubles with compressed message set

2013-01-30 Thread Jay Kreps
Ah, yes, the decision since we were making a breaking change to the protocol to just reset all the versions to 0. But if you are trying to handle both cases from the same code that will be hard. -Jay On Wed, Jan 30, 2013 at 12:59 PM, David Arthur wrote: > Jay, > > Figured it out. > > In Messag

Re: Troubles with compressed message set

2013-01-30 Thread David Arthur
On 1/30/13 11:18 AM, Jay Kreps wrote: Hi David, MessageSets aren't size delimited because that format is shared with producer/consumer and the kafka log itself. The log itself is just a big sequence of messages and any subset that begins and ends at valid message boundaries is a valid message s

Re: Troubles with compressed message set

2013-01-30 Thread David Arthur
Jay, Figured it out. In Message.scala, CurrentMagicValue is set to 0; should be 2. This was causing my client to attempt to decode it as a v0 message. Changing the value to 2 solved my problem. Seems like a trivial change, so I'll let you decided if you want a Jira or not. From my previous

Re: Troubles with compressed message set

2013-01-30 Thread Jay Kreps
Hi David, MessageSets aren't size delimited because that format is shared with producer/consumer and the kafka log itself. The log itself is just a big sequence of messages and any subset that begins and ends at valid message boundaries is a valid message set. This means that message sets are size