Re: Review Request 15665: Patch for KAFKA-1135

2013-11-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29176 --- Ship it! Ship It! - Jun Rao On Nov. 19, 2013, 3:21 a.m., Swapnil

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Guozhang Wang
> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29159 --- Ship it! - Guozhang Wang On Nov. 19, 2013, 3:21 a.m., Swapnil Ghi

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Swapnil Ghike
> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Guozhang Wang
> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Swapnil Ghike
> On Nov. 19, 2013, 5:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, line 52 > > > > > > Can we make the version number a global variable, so that when we > > upgrade i

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29126 --- Ship it! Ship It! - Neha Narkhede On Nov. 19, 2013, 3:21 a.m., S

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29116 --- core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- (Updated Nov. 19, 2013, 3:21 a.m.) Review request for kafka. Bugs: KAFKA-1135

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- (Updated Nov. 19, 2013, 3:17 a.m.) Review request for kafka. Summary (updated