Re: Review Request 16360: Fix the offset bug while adding fetchers

2014-01-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Jan. 16, 2014, 12:43 a.m.) Review request for kafka. Summary

Re: Review Request 16360: Fix the offset bug while adding fetchers

2014-01-15 Thread Guozhang Wang
On Jan. 7, 2014, 5:12 p.m., Neha Narkhede wrote: In general, does the alternate approach of sending all commands to every broker and let the broker ignore a become follower if it is for the same leader as the current one? The reason why this would work is because all

Re: Review Request 16360: Fix the offset bug while adding fetchers

2014-01-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review32002 --- Looks good. Just a couple of minor comments.