Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/ --- Review request for kafka. Bugs: KAFKA-1055 https://issues.apache.org/jira/b

Re: Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/#review32174 --- Looks good - should we add a separate metric for any dropped message

Re: Review Request 17055: Patch for KAFKA-1055

> On Jan. 17, 2014, 6:59 p.m., Joel Koshy wrote: > > Looks good - should we add a separate metric for any dropped messages? The exception is caught in failedProduceRequestRate - Guozhang --- This is an automatically generated e-mail. To

Re: Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/#review32297 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 17055: Patch for KAFKA-1055

> On Jan. 20, 2014, 5:35 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 244 > > > > > > It is useful to know the incoming byte rate to a Kafka broker, in > > addition to knowing

Re: Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/ --- (Updated Jan. 21, 2014, 9:29 p.m.) Review request for kafka. Bugs: KAFKA-1055

Re: Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/#review32474 --- Ship it! Ship It! - Neha Narkhede On Jan. 21, 2014, 9:29 p.m., G

Re: Review Request 17055: Patch for KAFKA-1055

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/#review32772 --- Ship it! - Joel Koshy On Jan. 21, 2014, 9:29 p.m., Guozhang Wang