Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review44964 --- If a consumer fails to establish a connection to zookeeper, how is t

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review43558 --- Ship it! clients/src/main/java/org/apache/kafka/clients/consumer/C

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 20, 2014, 11:34 p.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

> On May 19, 2014, 6:51 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > lines 27-28 > > > > > > Have we added the config for selecting the strategy for assigni

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 20, 2014, 10:55 p.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

> On May 19, 2014, 6:22 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java, > > lines 99-119 > > > > > > Should we discuss about code conventions of using ellipse (i.e

Re: Review Request 19731: Patch for KAFKA-1328

> On May 19, 2014, 5:30 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java, > > lines 70-71 > > > > > > Instead of introducing ConsumerRecords, I'd prefer just returning >

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review43395 --- clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerCon

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review43385 --- clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.ja

Re: Review Request 19731: Patch for KAFKA-1328

> On May 19, 2014, 5:30 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java, > > lines 70-71 > > > > > > Instead of introducing ConsumerRecords, I'd prefer just returning >

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review43365 --- clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.ja

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 16, 2014, 6:46 p.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 10, 2014, 12:18 a.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review42405 --- The javadoc for KafkaConsumer is missing in http://people.apache.or

Re: Review Request 19731: Patch for KAFKA-1328

> On May 7, 2014, 4:50 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java, > > lines 37-38 > > > > > > partitionId can probably be just partition to be consistent wit

Re: Review Request 19731: Patch for KAFKA-1328

> On May 7, 2014, 4:50 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java, > > lines 87-88 > > > > > > The Future thing doesn't work well in this case. This is because the >

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review42787 --- clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerCon

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 5, 2014, 6:35 p.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated May 5, 2014, 6:35 p.m.) Review request for kafka. Bugs: KAFKA-1328

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review41974 --- clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.ja

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review40856 --- 1. I am not sure about the use of ellipsis. This may make passing a

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review40262 --- Some general comments: 1. Do we need to take parameters for positio

Re: Review Request 19731: Patch for KAFKA-1328

> On April 7, 2014, 6:03 p.m., Guozhang Wang wrote: > > clients/src/main/java/kafka/clients/consumer/ConsumerRecord.java, line 22 > > > > > > Suggest add the following functions: > > > > compressionType() > >

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 13, 2014, 2:12 a.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 13, 2014, 1:30 a.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 6:16 p.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 5:54 p.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 1:30 a.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 11, 2014, 12:13 a.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19731: Patch for KAFKA-1328

> On April 7, 2014, 6:03 p.m., Guozhang Wang wrote: > > clients/src/main/java/kafka/clients/consumer/ConsumerConfig.java, line 55 > > > > > > ENABLE_AUTO_COMMIT_CONFIG to be consistent with ENABLE_JMX_CONFIG > > Neha N

Re: Review Request 19731: Patch for KAFKA-1328

> On April 7, 2014, 6:03 p.m., Guozhang Wang wrote: > > clients/src/main/java/kafka/clients/consumer/Consumer.java, line 41 > > > > > > Just wanted to confirm again that we agree to expose TopicPartition to > > users?

Re: Review Request 19731: Patch for KAFKA-1328

> On April 7, 2014, 6:13 p.m., Timothy Chen wrote: > > clients/src/main/java/kafka/clients/consumer/Consumer.java, line 61 > > > > > > I wonder if it's worth adding more comments about the poll behavior > > here, about

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review39694 --- clients/src/main/java/kafka/clients/consumer/Consumer.java

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review39700 --- clients/src/main/java/kafka/clients/consumer/Consumer.java

Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- Review request for kafka. Bugs: KAFKA-1328 https://issues.apache.org/jira/b