Review Request 21616: Patch for KAFKA-924

2014-05-18 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- Review request for kafka. Bugs: KAFKA-924 https://issues.apache.org/jira/br

Re: Review Request 21616: Patch for KAFKA-924

2014-05-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review43778 --- core/src/main/scala/kafka/consumer/ConsoleConsumer.scala

Re: Review Request 21616: Patch for KAFKA-924

2014-05-23 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 23, 2014, 9:47 p.m.) Review request for kafka. Bugs: KAFKA-924

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review43991 --- core/src/main/scala/kafka/consumer/ConsoleConsumer.scala

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 27, 2014, 9:51 p.m.) Review request for kafka. Bugs: KAFKA-924

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review44053 --- Ship it! Ship It! - Neha Narkhede On May 27, 2014, 9:51 p.m., Sr

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review44074 --- Ship it! Ship It! - Guozhang Wang On May 27, 2014, 9:51 p.m., Sr

Re: Review Request 21616: Patch for KAFKA-924

2014-05-28 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 29, 2014, 12:47 a.m.) Review request for kafka. Bugs: KAFKA-924

Re: Review Request 21616: Patch for KAFKA-924

2014-05-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review44232 --- There seems to be a bunch of white space changes. Could we remove th

Re: Review Request 21616: Patch for KAFKA-924

2014-05-29 Thread Neha Narkhede
> On May 29, 2014, 4:19 a.m., Jun Rao wrote: > > There seems to be a bunch of white space changes. Could we remove them? Jun, it seems to me that we had whitespaces before that this patch infact removes. - Neha --- This is an automatic

Re: Review Request 21616: Patch for KAFKA-924

2014-05-29 Thread Sriharsha Chintalapani
> On May 29, 2014, 4:19 a.m., Jun Rao wrote: > > There seems to be a bunch of white space changes. Could we remove them? > > Neha Narkhede wrote: > Jun, it seems to me that we had whitespaces before that this patch infact > removes. looks like my editor did that. If whitespace changes are

Re: Review Request 21616: Patch for KAFKA-924

2014-05-29 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 30, 2014, 1:34 a.m.) Review request for kafka. Bugs: KAFKA-924

Re: Review Request 21616: Patch for KAFKA-924

2014-05-29 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 30, 2014, 1:40 a.m.) Review request for kafka. Bugs: KAFKA-924

Re: Review Request 21616: Patch for KAFKA-924

2014-05-30 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/ --- (Updated May 30, 2014, 6:26 p.m.) Review request for kafka. Bugs: KAFKA-924