Re: Review Request 21663: Patch for KAFKA-1456

Yeah I meant to get to that Friday... Created subtask KAFKA-1471 to address this https://reviews.apache.org/r/21938/ On Mon, May 26, 2014 at 8:40 AM, Joe Stein wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21663/ > > On May 23rd, 2014, 5

Re: Review Request 21663: Patch for KAFKA-1456

> On May 23, 2014, 5:28 p.m., Jun Rao wrote: > > Thanks for the patch. Could we add the new codec in ProducerCompressionTest > > and MessageTest too? Sorry I missed this comment about ProducerCompressionTest the code is in MessageTest MessageCompressionTest and yes should be in ProducerCompres

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43937 --- Ship it! Ship It! - Joe Stein On May 20, 2014, 6:24 a.m., James

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43842 --- Thanks for the patch. Could we add the new codec in ProducerCompress

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43783 --- Can we add unit tests for the new compression codecs? We heavily dep

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43694 --- Reviewd code, applied patched and ran test cases. Looks good so far

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ --- (Updated May 20, 2014, 6:24 a.m.) Review request for kafka. Summary (updated)

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43455 --- Test cases failing: :clients:test ... org.apache.kafka.common.recor

Re: Review Request 21663: Patch for KAFKA-1456

> On May 20, 2014, 1:16 a.m., Joe Stein wrote: > > system_test/producer_perf/bin/run-compression-test-all.sh, line 1 > > > > > > In addition to what you added here can you also please add test cases > > for the compress

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ --- (Updated May 20, 2014, 1:19 a.m.) Review request for kafka. Bugs: KAFKA-1456

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43453 --- system_test/producer_perf/bin/run-compression-test-all.sh

Re: Review Request 21663: Patch for KAFKA-1456

> On May 19, 2014, 11 p.m., Joe Stein wrote: > > system_test/producer_perf/config/server.properties, line 18 > > > > > > There are dozens of changes to this file. When making a patch start > > with a clean trunk that

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ --- (Updated May 19, 2014, 11:39 p.m.) Review request for kafka. Bugs: KAFKA-1456

Re: Review Request 21663: Patch for KAFKA-1456

> On May 19, 2014, 11:08 p.m., Joe Stein wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressionType.java, > > line 45 > > > > > > This is the id that comes back to make the COMPRESSION_CODEC_MASK &

Re: Review Request 21663: Patch for KAFKA-1456

> On May 19, 2014, 10:58 p.m., Joe Stein wrote: > > core/src/main/scala/kafka/message/Message.scala, line 60 > > > > > > Why does the CompressionCodeMask have to change from 0x03 to 0x07 ? I > > see this as a client br

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43441 --- clients/src/main/java/org/apache/kafka/common/record/CompressionTyp

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43439 --- system_test/producer_perf/config/server.properties

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43440 --- Can you please add test cases for this in MessageCompressionTest.sca

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/#review43437 --- core/src/main/scala/kafka/message/Message.scala

Re: Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ --- (Updated May 19, 2014, 10:01 p.m.) Review request for kafka. Bugs: KAFKA-1456

Review Request 21663: Patch for KAFKA-1456

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ --- Review request for kafka. Bugs: KAFKA-1456 https://issues.apache.org/jira/b