Re: Review Request 23339: Patch for KAFKA-1507

> On July 28, 2014, 3:16 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java, > > lines 56-57 > > > > > > We need to pass in the createTopic flag in this constructor

Re: Review Request 23339: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/#review48822 --- Thanks for the patch. A few more comments below. clients/src/main/

Re: Review Request 23339: Patch for KAFKA-1507

> On July 22, 2014, 6:52 p.m., Jun Rao wrote: > > Thanks for the patch and doing the rebasing. Some comments below. Thanks for the review. I've noticed NetworkClient.java always uses the latestVersion of an api. There doesn't look like the way I can send specific version of a request since the

Re: Review Request 23339: Patch for KAFKA-1507

> On July 22, 2014, 6:52 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, lines 86-87 > > > > > > Perhaps this method can be named better since it may not just be for > > the consumer. Chan

Re: Review Request 23339: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/ --- (Updated July 24, 2014, 12:07 a.m.) Review request for kafka. Bugs: KAFKA-150

Re: Review Request 23339: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/#review48397 --- Thanks for the patch and doing the rebasing. Some comments below.

Re: Review Request 23339: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/ --- (Updated July 22, 2014, 5:27 p.m.) Review request for kafka. Bugs: KAFKA-1507

Review Request 23339: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/ --- Review request for kafka. Bugs: KAFKA-1507 https://issues.apache.org/jira/b