Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Dong Lin
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Dong Lin
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Timothy Chen
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Dong Lin
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Timothy Chen
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Dong Lin
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-06 Thread Timothy Chen
On Aug. 6, 2014, 5:32 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 I'm just trying to think if there is a chance to have overlapping tx ids especially around

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated Aug. 6, 2014, 4:25 a.m.) Review request for kafka. Bugs: KAFKA-1523

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review49692 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Dong Lin
On Aug. 6, 2014, 4:39 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 If the batch size changes to a smaller number does the tx Id range overlap then? Why? The

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review49696 --- core/src/main/scala/kafka/server/TransactionManager.scala

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated July 22, 2014, 11:45 p.m.) Review request for kafka. Bugs:

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-22 Thread Dong Lin
On July 21, 2014, 6:56 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 157 https://reviews.apache.org/r/23568/diff/4/?file=635099#file635099line157 Looking at this method in the other patch - this only gives the head - what about the other

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review48261 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-17 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review48011 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-17 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated July 18, 2014, 2:26 a.m.) Review request for kafka. Bugs:

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-17 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated July 18, 2014, 3:01 a.m.) Review request for kafka. Bugs:

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-17 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated July 18, 2014, 3:12 a.m.) Review request for kafka. Bugs:

Review Request 23568: Patch for KAFKA-1523

2014-07-16 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- Review request for kafka. Bugs: KAFKA-1523