Re: Review Request 25136: KAFKA-1610-Review Request

> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 20 > > > > > > Is this necessary? ReassignedPartitionContext seems not used anywhere. No. I

Re: Review Request 25136: KAFKA-1610-Review Request

> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > Thanks for the patch, some general comments: > > > > 1. In general we would like to avoid using ._1 and ._2 simply due to > > clarity of the code; instead we can use { case (key, value) => }. > > 2. After thinking about it twice, I think

Re: Review Request 25136: KAFKA-1610-Review Request

> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > Thanks for the patch, some general comments: > > > > 1. In general we would like to avoid using ._1 and ._2 simply due to > > clarity of the code; instead we can use { case (key, value) => }. > > 2. After thinking about it twice, I think

Re: Review Request 25136: KAFKA-1610-Review Request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Aug. 28, 2014, 6:12 p.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: KAFKA-1610-Review Request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review51793 --- Thanks for the patch, some general comments: 1. In general we woul

Review Request 25136: KAFKA-1610-Review Request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- Review request for kafka. Bugs: KAFKA-1610 https://issues.apache.org/jira/b