Re: Review Request 25136: Patch for KAFKA-1610

2014-10-02 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Oct. 2, 2014, 7:09 p.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: Patch for KAFKA-1610

2014-10-02 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Oct. 2, 2014, 7:07 p.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-30 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Oct. 1, 2014, 6:21 a.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-30 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review54990 --- Thanks for the updated patch. This looks fine - however, wouldn't it

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-16 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Sept. 16, 2014, 10:23 p.m.) Review request for kafka. Bugs: KAFKA-16

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review53574 --- Looks got to me, just some minor comments below. Joel, could you tak

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-16 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Sept. 16, 2014, 8:08 p.m.) Review request for kafka. Bugs: KAFKA-161

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-15 Thread Mayuresh Gharat
> On Sept. 15, 2014, 7:49 p.m., Guozhang Wang wrote: > > Have talked with Mayuresh and Joel about which mapValues should be > > converted to map. The summary is that > > > > 1. For now the only place we do in-place modification of a map is in > > ProducePartitionStatus, on isAcksPending and Er

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-15 Thread Joel Koshy
> On Sept. 15, 2014, 7:49 p.m., Guozhang Wang wrote: > > Have talked with Mayuresh and Joel about which mapValues should be > > converted to map. The summary is that > > > > 1. For now the only place we do in-place modification of a map is in > > ProducePartitionStatus, on isAcksPending and Er

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-15 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review53391 --- Have talked with Mayuresh and Joel about which mapValues should be c

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-14 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review53292 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-09 Thread Guozhang Wang
> On Sept. 9, 2014, 1:38 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 125 > > > > > > I don't think this is required, since we are subsequently doing a map > > over

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-08 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review52660 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review52234 --- Ship it! Ship It! - Guozhang Wang On Sept. 3, 2014, 6:27 p.m., M

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-03 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Sept. 3, 2014, 6:27 p.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: Patch for KAFKA-1610

2014-09-02 Thread Mayuresh Gharat
> On Aug. 29, 2014, 9:01 p.m., Guozhang Wang wrote: > > LGTM. One minor thing about comments is that we do not need to say > > "Changing mapValues to map" since we do not need to leave comments > > indicating code change, but just comment on the purpose of coding. We can > > generally say sth.

Re: Review Request 25136: Patch for KAFKA-1610

2014-08-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review51909 --- LGTM. One minor thing about comments is that we do not need to say "

Re: Review Request 25136: Patch for KAFKA-1610

2014-08-29 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Aug. 29, 2014, 5:04 p.m.) Review request for kafka. Bugs: KAFKA-1610

Re: Review Request 25136: Patch for KAFKA-1610

2014-08-29 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ --- (Updated Aug. 29, 2014, 4:51 p.m.) Review request for kafka. Summary (updated