On Oct. 27, 2014, 12:13 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 122
https://reviews.apache.org/r/26885/diff/3/?file=731636#file731636line122
The comments When connecting or connected, this handles slow/stalled
connections
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26885/#review58575
---
Ship it!
LGTM, with one minor comment below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26885/#review57513
---
Thanks for the patch. Looks good to me. Some minor comments below.
On Oct. 23, 2014, 9:43 p.m., Jun Rao wrote:
clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java,
lines 197-199
https://reviews.apache.org/r/26885/diff/2/?file=726776#file726776line197
It seems that in this case, the nextReadyCheckDelayMs should be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26885/
---
(Updated Oct. 23, 2014, 11:19 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26885/
---
(Updated Oct. 21, 2014, 12:34 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26885/
---
Review request for kafka.
Bugs: KAFKA-1642
