Re: Review Request 27204: Patch for KAFKA-1683

2015-04-24 Thread Sriharsha Chintalapani
On April 24, 2015, 7:07 p.m., Gari Singh wrote: 1) I think that Session should take a Subject rather than just a single Principal. The reason for this is because a Subject can have multiple Principals (for example both a username and a group or perhaps someone would want to use both

Re: Review Request 27204: Patch for KAFKA-1683

2015-04-24 Thread Gari Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27204/#review81522 --- 1) I think that Session should take a Subject rather than just a

Review Request 27204: Patch for KAFKA-1683

2014-10-25 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27204/ --- Review request for kafka. Bugs: KAFKA-1683