Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- (Updated Dec. 3, 2014, 9:34 p.m.) Review request for kafka. Bugs: KAFKA-1720

Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Guozhang Wang
> On Nov. 25, 2014, 5:50 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 87 > > > > > > In Kafka-1583 we had discussed renaming ReplicaManager to > > ReplicatedLogManager or some

Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review63803 --- Ship it! Ship It! - Joel Koshy On Dec. 3, 2014, 9:34 p.m., Guozh

Re: Review Request 27430: Fix KAFKA-1720

2014-11-25 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review63003 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review59453 --- Ship it! LGTM :) - Gwen Shapira On Nov. 1, 2014, 12:21 a.m., Guo

Re: Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- (Updated Nov. 1, 2014, 12:21 a.m.) Review request for kafka. Bugs: KAFKA-1720

Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- Review request for kafka. Bugs: KAFKA-1720 https://issues.apache.org/jira/b