---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 29, 2015, 11:20 a.m.)
Review request for kafka.
Bugs:
On Jan. 20, 2015, 8:03 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/KafkaClient.java, lines 30-33
https://reviews.apache.org/r/27799/diff/3/?file=824651#file824651line30
Wondering why we make newline for @param but keep the same line for
@return?
On Jan. 27, 2015, 10:25 a.m., Onur Karaman wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java,
line 205
https://reviews.apache.org/r/27799/diff/7/?file=832174#file832174line205
You left a blah.
This one is actually intentional. We haven't
On Jan. 28, 2015, 1:34 a.m., Guozhang Wang wrote:
patch -p1 patch-file does not do the renaming of
RequestCompletionHandler.java so I have to do that manually (weird), but
other than that, build / test LGTM.
It seems some of previous comments are not addressed yet. For exmaple
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Jay Kreps
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review70291
---
Ship it!
- Guozhang Wang
On Jan. 29, 2015, 11:20 a.m., Jay Kreps
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69936
---
patch -p1 patch-file does not do the renaming of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69737
---
minor nitpicks
On Jan. 22, 2015, 7:10 p.m., Guozhang Wang wrote:
core/src/test/scala/integration/kafka/api/ConsumerTest.scala, line 64
https://reviews.apache.org/r/27799/diff/5/?file=830064#file830064line64
Shall we add the @Test label just in case?
Jay Kreps wrote:
No I don't think so. I
On Jan. 23, 2015, 8:57 a.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 247
https://reviews.apache.org/r/27799/diff/6/?file=831485#file831485line247
I think these methods need to have timeouts on them. They get called
via
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69453
---
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 23, 2015, 9:15 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 23, 2015, 9:15 p.m.)
Review request for kafka.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 23, 2015, 9:13 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69355
---
On Jan. 22, 2015, 7:10 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
198
https://reviews.apache.org/r/27799/diff/4/?file=828402#file828402line198
Just trying to understand the rationale why we want to special-care for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 23, 2015, 4:22 a.m.)
Review request for kafka.
Bugs:
On Jan. 22, 2015, 7:10 p.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/utils/TestUtils.scala, lines 733-743
https://reviews.apache.org/r/27799/diff/5/?file=830071#file830071line733
Is this the same as createTopic in line 172?
Jay Kreps wrote:
Yeah, weird, I swear I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review68947
---
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Can you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 22, 2015, 6:03 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 22, 2015, 6:06 p.m.)
Review request for kafka.
Bugs:
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Jay Kreps
On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java,
line 21
https://reviews.apache.org/r/27799/diff/4/?file=828377#file828377line21
nit. Can we remove the public from the interface methods?
Jay Kreps
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69204
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 21, 2015, 4:42 p.m.)
Review request for kafka.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/
---
(Updated Jan. 21, 2015, 4:47 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69121
---
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
On Jan. 22, 2015, 3:14 a.m., Jaikiran Pai wrote:
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 253
https://reviews.apache.org/r/27799/diff/4/?file=828376#file828376line253
Hi Jay,
I think doing this unmuteAll in a finally block might be a good
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27799/#review69117
---
30 matches
Mail list logo
