Re: Review Request 28027: Patch for KAFKA-1724

2015-02-23 Thread Jun Rao
> On Nov. 14, 2014, 2:39 a.m., Jun Rao wrote: > > Thanks for the patch. I am not sure if that's the right place to fix it > > though. The issue is that when KafkaController.onControllerResignation() is > > called, the controller wasn't actually active. A better fix is probably to > > guard thi

Re: Review Request 28027: Patch for KAFKA-1724

2014-11-13 Thread Sriharsha Chintalapani
> On Nov. 14, 2014, 2:39 a.m., Jun Rao wrote: > > Thanks for the patch. I am not sure if that's the right place to fix it > > though. The issue is that when KafkaController.onControllerResignation() is > > called, the controller wasn't actually active. A better fix is probably to > > guard thi

Re: Review Request 28027: Patch for KAFKA-1724

2014-11-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28027/#review61391 --- Thanks for the patch. I am not sure if that's the right place to fix

Review Request 28027: Patch for KAFKA-1724

2014-11-13 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28027/ --- Review request for kafka. Bugs: KAFKA-1724 https://issues.apache.org/jira/b