Re: Review Request 29072: Patch for kafka-1797

2015-01-05 Thread Jun Rao
On Jan. 2, 2015, 5:34 p.m., Jay Kreps wrote: I'm a little late to this party but I think there are a couple of issues we should address before the release: 1. Currently the producer defaults to org.apache.kafka.clients.consumer.ByteArrayDeserializer. It should not take a default.

Re: Review Request 29072: Patch for kafka-1797

2015-01-02 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29072/#review66523 --- I'm a little late to this party but I think there are a couple of

Re: Review Request 29072: Patch for kafka-1797

2014-12-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29072/ --- (Updated Dec. 17, 2014, 5:47 p.m.) Review request for kafka. Summary

Re: Review Request 29072: Patch for kafka-1797

2014-12-17 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29072/#review65383 --- Ship it! Ship It! - Neha Narkhede On Dec. 17, 2014, 5:47 p.m.,