Re: Review Request 29091: Improve 1646 fix by reduce check if Os.IsWindows

2015-04-11 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/#review79812 --- I think this looks more reasonable. I am pretty confused by the code

Re: Review Request 29091: Improve 1646 fix by reduce check if Os.IsWindows

2015-03-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/#review76688 --- core/src/main/scala/kafka/utils/Utils.scala

Re: Review Request 29091: Improve 1646 fix by reduce check if Os.IsWindows

2015-03-12 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated March 13, 2015, 3:12 a.m.) Review request for kafka. Bugs: KAFKA-164

Re: Review Request 29091: Improve 1646 fix by reduce check if Os.IsWindows

2015-03-12 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated March 13, 2015, 3:04 a.m.) Review request for kafka. Summary (update