Re: Review Request 30482: Add the coordinator to server

2015-02-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 6, 2015, 11:02 p.m.) Review request for kafka. Bugs: KAFKA-1333

Re: Review Request 30482: Add the coordinator to server

2015-02-08 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/#review71562 --- Ship it! Ship It! - Jay Kreps On Feb. 6, 2015, 11:02 p.m., Guozh

Re: Review Request 30482: Add the coordinator to server

2015-02-08 Thread Guozhang Wang
On Feb. 1, 2015, 8:46 p.m., Guozhang Wang wrote: > > Not sure this stuff is actually here for review...may still be a work in > > progress. Overall this structure of code makes a ton of sense to me. Left > > some minor comments. Yes this is more of a WIP patch, but the scope of this JIRA does

Re: Review Request 30482: Add the coordinator to server

2015-02-02 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/#review70535 --- core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala

Re: Review Request 30482: Add the coordinator to server

2015-02-01 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/#review70533 --- core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala

Re: Review Request 30482: Add the coordinator to server

2015-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 2:45 a.m.) Review request for kafka. Bugs: KAFKA-1333

Re: Review Request 30482: Add the coordinator to server

2015-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 1:47 a.m.) Review request for kafka. Bugs: KAFKA-1333

Re: Review Request 30482: Add the coordinator to server

2015-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 1:40 a.m.) Review request for kafka. Bugs: KAFKA-1333

Review Request 30482: Add the coordinator to server

2015-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- Review request for kafka. Bugs: KAFKA-1633 https://issues.apache.org/jira/b