Re: Review Request 31040: Patch for kafka-1952

2015-02-15 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/#review72559 --- Ship it! Ship It! - Neha Narkhede On Feb. 15, 2015, 11:26 p.m.,

Re: Review Request 31040: Patch for kafka-1952

2015-02-15 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/ --- (Updated Feb. 15, 2015, 11:26 p.m.) Review request for kafka. Bugs: kafka-195

Re: Review Request 31040: Patch for kafka-1952

2015-02-15 Thread Jun Rao
> On Feb. 14, 2015, 5 a.m., Ewen Cheslack-Postava wrote: > > core/src/main/scala/kafka/server/RequestPurgatory.scala, line 136 > > > > > > The > > > > if (t.satisfied.get) > > return false > > > >

Re: Review Request 31040: Patch for kafka-1952

2015-02-14 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/#review72482 --- Minor question about a check that got removed, but otherwise LGTM.

Re: Review Request 31040: Patch for kafka-1952

2015-02-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/#review72479 --- Ship it! core/src/main/scala/kafka/server/RequestPurgatory.scala <

Review Request 31040: Patch for kafka-1952

2015-02-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31040/ --- Review request for kafka. Bugs: kafka-1952 https://issues.apache.org/jira/b